Perl-Critic v1.152 Perl 5 v5.32.1 x86_64-cygwin-threads-multi

Status
Fail
From
David Solimano
Dist
Perl-Critic v1.152
Platform
Perl 5 v5.32.1 x86_64-cygwin-threads-multi
Date
2023-10-17 15:35:48
ID
d7d86c8c-7f2e-1014-81f2-491707f7812f
This distribution has been tested as part of the CPAN Testers
project, supporting the Perl programming language.  See
http://wiki.cpantesters.org/ for more information or email
questions to cpan-testers-discuss@perl.org


--
Dear Andy Lester,

This is a computer-generated report for Perl-Critic-1.152
on perl 5.32.1, created by CPAN-Reporter-1.2018.

Thank you for uploading your work to CPAN.  However, there was a problem
testing your distribution.

If you think this report is invalid, please consult the CPAN Testers Wiki
for suggestions on how to avoid getting FAIL reports for missing library
or binary dependencies, unsupported operating systems, and so on:

http://wiki.cpantesters.org/wiki/CPANAuthorNotes

Sections of this report:

    * Tester comments
    * Program output
    * Prerequisites
    * Environment and other context

------------------------------
TESTER COMMENTS
------------------------------

Additional comments from tester:

this report is from an automated smoke testing program
and was not reviewed by a human for accuracy

------------------------------
PROGRAM OUTPUT
------------------------------

Output from './Build test':

# Testing Perl::Critic 1.152 with PPI 1.276 under Perl 5.032001, /usr/bin/perl
t/00_modules.t ................................ ok
t/00_versions.t ............................... ok
t/01_config.t ................................. ok
t/01_config_bad_perlcriticrc.t ................ ok
t/01_policy_config.t .......................... ok
t/02_policy.t ................................. ok
t/03_annotations.t ............................ ok
t/03_pragmas.t ................................ ok
t/04_options_processor.t ...................... ok
t/05_utils.t .................................. ok
t/05_utils_perl.t ............................. ok
t/05_utils_pod.t .............................. ok
t/05_utils_ppi.t .............................. ok
t/06_violation.t .............................. ok
t/07_command.t ................................ ok
t/07_perlcritic.t ............................. ok
t/08_document.t ............................... ok
t/09_theme.t .................................. ok
t/10_user_profile.t ........................... ok
t/11_policy_factory.t ......................... ok
t/12_policy_listing.t ......................... ok
t/12_theme_listing.t .......................... ok
t/13_bundled_policies.t ....................... ok
t/14_policy_parameter_behavior_boolean.t ...... ok
t/14_policy_parameter_behavior_enumeration.t .. ok
t/14_policy_parameter_behavior_integer.t ...... ok
t/14_policy_parameter_behavior_list_string.t .. ok
t/14_policy_parameter_behavior_string.t ....... ok
t/14_policy_parameters.t ...................... ok
t/15_statistics.t ............................. ok
t/16_roundtrip_defaults.t ..................... ok

#   Failed test 'Subroutines::RequireArgUnpacking - line 436 - Anonymous subroutine with attributes and/or prototypes'
#   at t/20_policies.t line 24.
# Expected 0 violations, got 1. Found violations follow...
# Found violation: Always unpack @_ first at line 2, column 1.  (sub foo {)
# Looks like you failed 1 test of 2783.
t/20_policies.t ............................... 
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/2783 subtests 
t/20_policy_pod_spelling.t .................... ok
t/20_policy_prohibit_evil_modules.t ........... ok
t/20_policy_prohibit_hard_tabs.t .............. ok
t/20_policy_prohibit_trailing_whitespace.t .... ok
t/20_policy_require_consistent_newlines.t ..... ok
t/20_policy_require_tidy_code.t ............... ok
t/92_memory_leaks.t ........................... skipped: Test::Memory::Cycle required to test memory leaks
t/gh-734.t .................................... ok

Test Summary Report
-------------------
t/20_policies.t                             (Wstat: 256 (exited 1) Tests: 2783 Failed: 1)
  Failed test:  2181
  Non-zero exit status: 1
Files=40, Tests=8171, 648 wallclock secs ( 0.34 usr  0.84 sys + 90.69 cusr 53.90 csys = 145.78 CPU)
Result: FAIL
Failed 1/40 test programs. 1/8171 subtests failed.

------------------------------
PREREQUISITES
------------------------------

Prerequisite modules loaded:

requires:

    Module                    Need     Have    
    ------------------------- -------- --------
    B::Keywords               1.23     1.26    
    Carp                      0        1.50    
    charnames                 0        1.48    
    Config::Tiny              2        2.29    
    English                   0        1.11    
    Exception::Class          1.23     1.45    
    Exporter                  5.63     5.77    
    File::Basename            0        2.85    
    File::Find                0        1.37    
    File::Path                0        2.18    
    File::Spec                0        3.78    
    File::Spec::Unix          0        3.78    
    File::Temp                0        0.2311  
    File::Which               0        1.27    
    Getopt::Long              0        2.54    
    List::SomeUtils           0.55     0.59    
    List::Util                0        1.63    
    Module::Pluggable         3.1      5.2     
    overload                  0        1.31    
    parent                    0        0.241   
    perl                      5.010001 5.032001
    Perl::Tidy                0        20230701
    Pod::PlainText            0        2.07    
    Pod::Select               0        1.66    
    Pod::Spell                1        1.26    
    Pod::Usage                0        2.03    
    PPI                       1.277    1.277   
    PPI::Document             1.277    1.277   
    PPI::Document::File       1.277    1.277   
    PPI::Node                 1.277    1.277   
    PPI::Token::Quote::Single 1.277    1.277   
    PPI::Token::Whitespace    1.277    1.277   
    PPIx::QuoteLike           0        0.023   
    PPIx::Regexp              0.027    0.088   
    PPIx::Regexp::Util        0.068    0.088   
    PPIx::Utils::Traversal    0.003    0.003   
    Readonly                  2        2.05    
    Scalar::Util              0        1.63    
    strict                    0        1.11    
    String::Format            1.18     1.18    
    Term::ANSIColor           2.02     5.01    
    Test::Builder             0.92     1.302195
    Text::ParseWords          3        3.31    
    version                   0.77     0.9929  
    warnings                  0        1.47    

build_requires:

    Module                    Need     Have    
    ------------------------- -------- --------
    lib                       0        0.65    
    Test::More                0        1.302195

configure_requires:

    Module                    Need     Have    
    ------------------------- -------- --------
    B::Keywords               1.23     1.26    
    base                      0        2.27    
    Carp                      0        1.50    
    English                   0        1.11    
    Exporter                  5.63     5.77    
    lib                       0        0.65    
    List::SomeUtils           0.55     0.59    
    Module::Build             0.4204   0.4234  


------------------------------
ENVIRONMENT AND OTHER CONTEXT
------------------------------

Environment variables:

    AUTOMATED_TESTING = 1
    COMSPEC = C:\WINDOWS\system32\cmd.exe
    LANG = en_US.UTF-8
    LC_CTYPE = en_US.UTF-8
    NUMBER_OF_PROCESSORS = 8
    PATH = /home/solimanod/perl5/bin:/usr/local/bin:/usr/bin:/cygdrive/c/Program Files/Eclipse Foundation/jdk-8.0.302.8-hotspot/bin:/cygdrive/c/Program Files/Microsoft/jdk-11.0.12.7-hotspot/bin:/cygdrive/c/WINDOWS/system32:/cygdrive/c/WINDOWS:/cygdrive/c/WINDOWS/System32/Wbem:/cygdrive/c/WINDOWS/System32/WindowsPowerShell/v1.0:/cygdrive/c/WINDOWS/System32/OpenSSH:/cygdrive/c/Program Files/TortoiseSVN/bin:/cygdrive/c/RV/BIN:/cygdrive/c/Program Files/Microsoft SQL Server/130/Tools/Binn:/cygdrive/c/Program Files/Microsoft SQL Server/Client SDK/ODBC/170/Tools/Binn:/cygdrive/c/Program Files (x86)/Microsoft SQL Server/150/DTS/Binn:/cygdrive/c/Program Files/SlikSvn/bin:/cygdrive/c/Program Files/dotnet:/cygdrive/c/Program Files/Microsoft SQL Server/150/Tools/Binn:/cygdrive/c/Program Files/Git/cmd:/cygdrive/c/Program Files/Azure Data Studio/bin:/cygdrive/c/Program Files/MIT/Kerberos/bin:/cygdrive/c/Program Files/TortoiseGit/bin:/cygdrive/c/Strawberry/c/bin:/cygdrive/c/Strawberry/perl/site/bin:/cygdrive/c/Strawberry/perl/bin:/cygdrive/c/Users/solimanod/AppData/Local/Microsoft/WindowsApps
    PERL5LIB = /home/solimanod/.cpan/build/PPI-1.277-0/blib/arch:/home/solimanod/.cpan/build/PPI-1.277-0/blib/lib:/home/solimanod/perl5/lib/perl5
    PERL5OPT = 
    PERL5_CPANPLUS_IS_RUNNING = 65069
    PERL5_CPAN_IS_RUNNING = 65069
    PERL5_CPAN_IS_RUNNING_IN_RECURSION = 62627,65069
    PERL_CR_SMOKER_CURRENT = Perl-Critic-1.152
    PERL_EXTUTILS_AUTOINSTALL = --defaultdeps
    PERL_LOCAL_LIB_ROOT = /home/solimanod/perl5
    PERL_MB_OPT = --install_base "/home/solimanod/perl5"
    PERL_MM_OPT = INSTALL_BASE=/home/solimanod/perl5
    PERL_MM_USE_DEFAULT = 1
    PERL_USE_UNSAFE_INC = 1
    PROCESSOR_IDENTIFIER = Intel64 Family 6 Model 158 Stepping 13, GenuineIntel
    SHELL = /bin/bash
    TEMP = /tmp
    TERM = xterm-direct

Perl special variables (and OS-specific diagnostics, for MSWin32):

    $^X = /usr/bin/perl
    $UID/$EUID = 1222856 / 1222856
    $GID = 1049089 1049089 555 545 559 4 66049 11 15 4095 66048 1442607 1395145 1445950 1231332 1425386 1445955 1391115 1413001 1411909 1412494 1389702 1110237 1417682 1391333 1392133 1461501 1445942 1446043 1425217 1406572 1413600 1425390 1389528 1404926 1438665 1407957 1390371 1442777 1425384 1413376 1389547 1395162 1433132 1394012 1417205 1395231 1432903 1417681 1405122 1440263 1392391 1462048 1392334 1449512 1440279 1440135 1417368 1391057 1321713 1395423 1389592 1399936 1464134 1445956 1433745 1433017 1440082 1411964 1449625 1389176 1425082 1445951 1230946 1390011 1442589 1449871 1389527 1391236 1395210 1413378 1389747 1412518 1442553 1291952 1446063 1438721 1425382 1321739 1413351 1391275 1391014 1438720 1462117 1448155 1440100 1406893 1275909 1404927 1449443 1439627 1110272 1464123 1433010 1433135 1100291 1394449 1448223 1394915 1389439 1395569 1222766 1222819 1417887 1222732 1114690 1231058 1275974 1292197 1222743 1222741 1389953 1233131 1054841 1300831 1052870 1050371 1049701 1049741 1049748 1049779 1049783 1058315 1051691 1049994 1050059 1052837 1235940 70145 1049735 1053718 1074460 1082199 1069023 1058356 1236080 1236107 1448072 1449693 1393994 1462255 1448088 1054462 1321972 1404982 1291964 1291449 1448276 1388773 1448090 1395282 1291954 1291893 1403164 1276307 1425681 1292037 1462256 1158631 1448094 1448086 1425178 1292385 1291940 1054217 1403700 1448074 1417070 1448080 1389585 1292046 1231333 1448084 1222696 1413320 1462258 1448078 1404984 1448082 1291966 1291957 1063805 1289842 1388864 1399756 1388423 1291953 1448092 1462259 1448076 1462257 1276165 401408
    $EGID = 1049089 1049089 555 545 559 4 66049 11 15 4095 66048 1442607 1395145 1445950 1231332 1425386 1445955 1391115 1413001 1411909 1412494 1389702 1110237 1417682 1391333 1392133 1461501 1445942 1446043 1425217 1406572 1413600 1425390 1389528 1404926 1438665 1407957 1390371 1442777 1425384 1413376 1389547 1395162 1433132 1394012 1417205 1395231 1432903 1417681 1405122 1440263 1392391 1462048 1392334 1449512 1440279 1440135 1417368 1391057 1321713 1395423 1389592 1399936 1464134 1445956 1433745 1433017 1440082 1411964 1449625 1389176 1425082 1445951 1230946 1390011 1442589 1449871 1389527 1391236 1395210 1413378 1389747 1412518 1442553 1291952 1446063 1438721 1425382 1321739 1413351 1391275 1391014 1438720 1462117 1448155 1440100 1406893 1275909 1404927 1449443 1439627 1110272 1464123 1433010 1433135 1100291 1394449 1448223 1394915 1389439 1395569 1222766 1222819 1417887 1222732 1114690 1231058 1275974 1292197 1222743 1222741 1389953 1233131 1054841 1300831 1052870 1050371 1049701 1049741 1049748 1049779 1049783 1058315 1051691 1049994 1050059 1052837 1235940 70145 1049735 1053718 1074460 1082199 1069023 1058356 1236080 1236107 1448072 1449693 1393994 1462255 1448088 1054462 1321972 1404982 1291964 1291449 1448276 1388773 1448090 1395282 1291954 1291893 1403164 1276307 1425681 1292037 1462256 1158631 1448094 1448086 1425178 1292385 1291940 1054217 1403700 1448074 1417070 1448080 1389585 1292046 1231333 1448084 1222696 1413320 1462258 1448078 1404984 1448082 1291966 1291957 1063805 1289842 1388864 1399756 1388423 1291953 1448092 1462259 1448076 1462257 1276165 401408

Perl module toolchain versions installed:

    Module              Have    
    ------------------- --------
    CPAN                2.34    
    CPAN::Meta          2.150010
    Cwd                 3.78    
    ExtUtils::CBuilder  0.280236
    ExtUtils::Command   7.70    
    ExtUtils::Install   2.22    
    ExtUtils::MakeMaker 7.70    
    ExtUtils::Manifest  1.75    
    ExtUtils::ParseXS   3.44    
    File::Spec          3.78    
    JSON                4.10    
    JSON::PP            4.16    
    Module::Build       0.4234  
    Module::Signature   0.88    
    Parse::CPAN::Meta   2.150010
    Test::Harness       3.44    
    Test::More          1.302195
    YAML                1.30    
    YAML::Syck          n/a     
    version             0.9929  


--

Summary of my perl5 (revision 5 version 32 subversion 1) configuration:
   
  Platform:
    osname=cygwin
    osvers=3.2.0(0.34053)
    archname=x86_64-cygwin-threads-multi
    uname='cygwin_nt-10.0 cygwinpro 3.2.0(0.34053) 2021-03-29 08:42 x86_64 cygwin '
    config_args='-des -Dprefix=/usr -Dmksymlinks -Darchname=x86_64-cygwin-threads -Dlibperl=cygperl5_32.dll -Dcc=gcc -Dld=g++ -Accflags=-ggdb -O2 -pipe -Wall -Werror=format-security -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -fdebug-prefix-map=/mnt/share/cygpkgs/perl/perl.x86_64/build=/usr/src/debug/perl-5.32.1-2 -fdebug-prefix-map=/mnt/share/cygpkgs/perl/perl.x86_64/src/perl-5.32.1=/usr/src/debug/perl-5.32.1-2 -fwrapv'
    hint=recommended
    useposix=true
    d_sigaction=define
    useithreads=define
    usemultiplicity=define
    use64bitint=define
    use64bitall=define
    uselongdouble=undef
    usemymalloc=n
    default_inc_excludes_dot=define
    bincompat5005=undef
  Compiler:
    cc='gcc'
    ccflags ='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -D_GNU_SOURCE -ggdb -O2 -pipe -Wall -Werror=format-security -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -fdebug-prefix-map=/mnt/share/cygpkgs/perl/perl.x86_64/build=/usr/src/debug/perl-5.32.1-2 -fdebug-prefix-map=/mnt/share/cygpkgs/perl/perl.x86_64/src/perl-5.32.1=/usr/src/debug/perl-5.32.1-2 -fwrapv -fno-strict-aliasing'
    optimize='-O3'
    cppflags='-DPERL_USE_SAFE_PUTENV -U__STRICT_ANSI__ -D_GNU_SOURCE -ggdb -O2 -pipe -Wall -Werror=format-security -D_FORTIFY_SOURCE=2 -fstack-protector-strong --param=ssp-buffer-size=4 -fdebug-prefix-map=/mnt/share/cygpkgs/perl/perl.x86_64/build=/usr/src/debug/perl-5.32.1-2 -fdebug-prefix-map=/mnt/share/cygpkgs/perl/perl.x86_64/src/perl-5.32.1=/usr/src/debug/perl-5.32.1-2 -fwrapv -fno-strict-aliasing'
    ccversion=''
    gccversion='10.2.0'
    gccosandvers=''
    intsize=4
    longsize=8
    ptrsize=8
    doublesize=8
    byteorder=12345678
    doublekind=3
    d_longlong=define
    longlongsize=8
    d_longdbl=define
    longdblsize=16
    longdblkind=3
    ivtype='long'
    ivsize=8
    nvtype='double'
    nvsize=8
    Off_t='off_t'
    lseeksize=8
    alignbytes=8
    prototype=define
  Linker and Libraries:
    ld='g++'
    ldflags =' -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--enable-auto-image-base -fstack-protector-strong'
    libpth=/usr/lib
    libs=-lpthread -lnsl -lgdbm -ldb -ldl -lcrypt -lgdbm_compat
    perllibs=-lpthread -lnsl -ldl -lcrypt
    libc=/usr/lib/libcygwin.a
    so=dll
    useshrplib=true
    libperl=cygperl5_32.dll
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs
    dlext=dll
    d_dlsymun=undef
    ccdlflags=' '
    cccdlflags=' '
    lddlflags=' --shared  -Wl,--enable-auto-import -Wl,--export-all-symbols -Wl,--enable-auto-image-base -fstack-protector-strong'


Characteristics of this binary (from libperl): 
  Compile-time options:
    HAS_TIMES
    MULTIPLICITY
    PERLIO_LAYERS
    PERL_COPY_ON_WRITE
    PERL_DONT_CREATE_GVSV
    PERL_IMPLICIT_CONTEXT
    PERL_OP_PARENT
    PERL_PRESERVE_IVUV
    PERL_USE_SAFE_PUTENV
    USE_64_BIT_ALL
    USE_64_BIT_INT
    USE_ITHREADS
    USE_LARGE_FILES
    USE_LOCALE
    USE_LOCALE_COLLATE
    USE_LOCALE_CTYPE
    USE_LOCALE_NUMERIC
    USE_LOCALE_TIME
    USE_PERLIO
    USE_PERL_ATOF
    USE_REENTRANT_API
    USE_THREAD_SAFE_LOCALE
  Locally applied patches:
    Cygwin: README
    Cygwin: use auto-image-base instead of fixed DLL base address
    Cygwin: modify hints
    Cygwin: Configure correct libsearch
    Cygwin: Configure correct libpth
    Cygwin: Encode fix for CVE-2021-36770
    Cygwin: Win32 correct UTF8 handling
  Built under cygwin
  Compiled at Aug 14 2021 09:07:12
  %ENV:
    PERL5LIB="/home/solimanod/.cpan/build/PPI-1.277-0/blib/arch:/home/solimanod/.cpan/build/PPI-1.277-0/blib/lib:/home/solimanod/perl5/lib/perl5"
    PERL5OPT=""
    PERL5_CPANPLUS_IS_RUNNING="65069"
    PERL5_CPAN_IS_RUNNING="65069"
    PERL5_CPAN_IS_RUNNING_IN_RECURSION="62627,65069"
    PERL_CR_SMOKER_CURRENT="Perl-Critic-1.152"
    PERL_EXTUTILS_AUTOINSTALL="--defaultdeps"
    PERL_LOCAL_LIB_ROOT="/home/solimanod/perl5"
    PERL_MB_OPT="--install_base "/home/solimanod/perl5""
    PERL_MM_OPT="INSTALL_BASE=/home/solimanod/perl5"
    PERL_MM_USE_DEFAULT="1"
    PERL_USE_UNSAFE_INC="1"
  @INC:
    /home/solimanod/.cpan/build/PPI-1.277-0/blib/arch
    /home/solimanod/.cpan/build/PPI-1.277-0/blib/lib
    /home/solimanod/perl5/lib/perl5/5.32.1/x86_64-cygwin-threads-multi
    /home/solimanod/perl5/lib/perl5/5.32.1
    /home/solimanod/perl5/lib/perl5/x86_64-cygwin-threads-multi
    /home/solimanod/perl5/lib/perl5
    /usr/local/lib/perl5/site_perl/5.32/x86_64-cygwin-threads
    /usr/local/share/perl5/site_perl/5.32
    /usr/lib/perl5/vendor_perl/5.32/x86_64-cygwin-threads
    /usr/share/perl5/vendor_perl/5.32
    /usr/lib/perl5/5.32/x86_64-cygwin-threads
    /usr/share/perl5/5.32
    .